Resize Popout to fit content on popout #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raplemie
reviewed
Oct 24, 2023
ui/appui-react/src/appui-react/childwindow/InternalChildWindowManager.tsx
Outdated
Show resolved
Hide resolved
raplemie
reviewed
Oct 25, 2023
ui/appui-react/src/appui-react/childwindow/InternalChildWindowManager.tsx
Outdated
Show resolved
Hide resolved
…Manager.tsx Co-authored-by: Raphaël LEMIEUX <[email protected]>
|
Working on adjusting it so that it is only sized like this on initial popout and not after resized |
raplemie
reviewed
Oct 31, 2023
raplemie
reviewed
Nov 1, 2023
…3-10-30-15-36.json
…to joeh/resizePopout
raplemie
approved these changes
Nov 3, 2023
ui/appui-layout-react/src/appui-layout-react/state/NineZoneStateReducer.ts
Outdated
Show resolved
Hide resolved
raplemie
reviewed
Nov 3, 2023
…teReducer.ts Co-authored-by: Raphaël LEMIEUX <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Originally popouts were set to the default window size of child windows on popout. They will now fit to their content inside on popout. This couldn't be done like how it was with floating widgets because that uses hooks and the popout needs to use class components. The preferredFloatingWidgetSize of the tab will be used to find the inital popout size when bounds are not set.
Testing
I tested the popout in the popout window frontstage. Pop it out from docking on each side and as a floating widget. I also tested in the exercise widget api frontstage.